Re: [PATCH] Refactoring url to original url (storeurl step 1)

Attached the patch v1 modified.

On 11/29/2012 6:39 AM, Eliezer Croitoru wrote:
>
>
> On 11/28/2012 6:36 PM, Alex Rousskov wrote:
>> On 11/27/2012 11:37 PM, Eliezer Croitoru wrote:
>>> The patch is refactoring of two variables:
>>> mem_object->url into mem_obj->original_url
>>> Store_entry->url into Store_entry->originalUrl
>>>
>>> Both are named inline with other variables in their scope.
>>> This is the first step towards Store_url completion.
>>
>> Please consider documenting the renamed method and data member by adding
>> a brief doxygen comment for them. After spending so much time with this
>> code, you probably know what these members are! :-)
I Will need some pointers\examples for such a thing.
It will not be integrated in this patch though.

>
> I kind of hope I know it :D
> Now I remember only little about it and I know more about specific other
> points in the code that make use of it.
> But I will try to put it in my list.
>>
>> The new comment in StoreMetaURL::checkConsistency() does not belong to
>> this patch, IMO. If you insist on keeping it, then please spellcheck
>> "rewritted".
> OK, I will add it later on.

Done.

Eliezer

-- 
Eliezer Croitoru
https://www1.ngtech.co.il
sip:ngtech_at_sip2sip.info
IT consulting for Nonprofit organizations
eliezer <at> ngtech.co.il