Re: [PATCH] Refactoring url to original url (storeurl step 1)

On 11/28/2012 09:39 PM, Eliezer Croitoru wrote:
> On 11/28/2012 6:36 PM, Alex Rousskov wrote:
>> Overall, I think this change is a very important step, but it should not
>> be committed until we have other steps (or at all):

> These point of change do reflect in major points of the code the
> distinction between the "store url" which is the original url and to the
> "store rewritten url".

This logic does not work in the scope of the proposed patch because
there is no rewritten URL.

Renaming "url" is a great tool in your project, and I did recommend it
as one of the first project steps, but renaming alone does more harm
than good and, hence, this patch should not be committed. In fact,
renaming alone does no good at all!

You need to make the next step of changing some of the instances of
original_url to rewritten_url before the cumulative patch will be worth
considering.

Hope this clarifies,

Alex.
Received on Fri Nov 30 2012 - 18:01:25 MST