Re: [squid-users] ignoring If-Modified-Since: from browsers, but still generating If-Modified-Since: requests

On Wed, Jun 21, 2006 at 03:32:52AM +0200, Henrik Nordstrom wrote:
> fre 2006-06-16 klockan 18:35 +0100 skrev Chris Lightfoot:
>
> > client. Therefore (and while we'd like to save the
> > bandwidth...) we need to have squid treat conditional GETs
> > as non-conditional; but obviously we still need to use
> > conditional GETs internally (otherwise we'd lose the
> > performance gain of using squid in the first place). Is
> > there a simple way to do this, or do I need to patch
> > squid?
>
> You need to patch Squid unfortunately, but isn't a very hard thing to
> do. Look for HDR_IF_MODIFIED_SINCE in client_side.c.

the patch is indeed simple -- for anyone in the same
situation, here's a patch for 2.5.9:

--- squid-2.5.9/src/client_side.c.orig 2006-06-21 12:49:20.000000000 +0100
+++ squid-2.5.9/src/client_side.c 2006-06-21 12:52:00.000000000 +0100
@@ -3104,6 +3104,12 @@
                safe_free(prefix);
                break;
            }
+
+ /* Many modern browsers do not correctly support If-Modified-Since:
+ * conditional GETs, so suppress that header in incoming requests.
+ * See https://bugzilla.mozilla.org/show_bug.cgi?id=269303 */
+ httpHeaderDelByName(&request->header, "If-Modified-Since");
+
            request->flags.accelerated = http->flags.accel;
            if (!http->flags.internal) {
                if (internalCheck(strBuf(request->urlpath))) {

-- 
``Press button for a 60-second speech from Cecil Parkinson.''
  (graffito, on electric hand drier in loo)