[squid-users] Re: [PATCH] Revised fix for download corruption

On Tue, 2002-11-05 at 08:47, Phil Oester wrote:
> Since I sent in my patch last week, I've discovered a few things:
>
> 1) at least one squid devloper questions my sanity on the squid-dev list:
>
> "This person is .. insane. Insane, insane, insane"

I believe Adrian was referring to your effort, in a positive, but
humourous way :}.

> 2) the patch was only partially correct. The problem only occurs on a cancelled READ, not on a write. Many times, due to write latency, flags->close_request has been set on a write before the data has been committed to disk. My original patch would cancel on writes also, so I ended up with a bunch of zero byte files in my cache.
>
> The below works for both reads and writes, as it only checks close_request for reads before returning the results to the client.

Have you seen Henriks suggested alteration as well, to prevent a
suspected memory overwrite on async writes?

Rob