Re: [squid-users] squid_ldap_group

Gerard Eviston wrote:

> > And you do have the source code.. making squid_ldap_group strip away the
> > domain is only one or two lines of code..
>
> It is easy to do but I imagine that I'm not the only one. Also the
> maintenance of site-specific patches makes it more of a pain to track the
> snapshots/prereleases in the lead up to 2.5. At the risk of feature creep
> would you consider adding it in?

Sure, this is how things work in the world of Open Source. The one needing
something makes sure it gets done one way or another, and if he thinks the
changes may be valuable to others he contributes it back. If it is agreed
that the feature may be of value to others and has good quality then it
generally gets accepted.

MARA systems have written the squid_ldap_group helper to match the needs we
and our customers have. As it is based on prior work by others and we think
it might be usable for others we have contributed this helper to the Squid
community along with the whole external_acl mechanism in Squid. So far we
have not needed the ability to strip away domains so we have not implemented
this in the helper. But ofcourse we are prepared to accept improvements by
others to the program if the changes have good quality and useability to
others.

One thing to watch out for is if you make significant contributions (making
squid_ldap_group strip away the domain component won't count as a significant
contribution I think, but it is better to be safe than sorry) then you should
verify with yout employer that it is OK to contribute your changes to the
Squid community.

Regards
Henrik
Received on Wed Sep 11 2002 - 05:01:31 MDT