Re: [PATCH 0/8] reconfiguration leaks

On 04/24/2014 06:22 PM, Alex Rousskov wrote:
> I am going to post several patches that fix various reconfiguration
> leaks. The patches will be posted in no particular order. Here is a
> Table of Contents:
>
> 1. implicit ACLs,
> 2. adaptation ACLs,
> 3. TcpAcceptor job,
> 4. Cache Manager menu items,
> 5. [SSL] objects tied to http_port and https_port,
> 6. fake SSL certificate context cache when reconfigure changes port,
> 7. SSL ex_data for SSL state that survived reconfigure, a 12 y.o. bug!
> 8. Excessive $HOME leak.

Status update: AFAICT, there is at least one and possibly two known
reconfigure leaks remaining:

1. implicit ACLs: Patch exists but Amos was not particularly happy about
it and nobody else voted. Long-term, a refcounting solution is probably
needed for all ACLs, but that would require a lot of code changes and
may cause its own leaks through refcounting loops if we are not careful
enough. This fix is stuck for now.

5. CfgPorts: Partial fixes have been committed, but the core of the
original patch resolving this leak is no longer applicable to trunk
because we are refcounting port structures now. Our recent tests show
that those structures may still be leaking, but we need to do more work
to confirm (and, if confirmed, fix) that.

Cheers,

Alex.
Received on Thu Aug 21 2014 - 00:56:55 MDT