Re: [PATCH] Kerberos configure patch + some cleanup

On 9/08/2014 8:32 a.m., Markus Moeller wrote:
> It should be in there or did I miss some ?

The original bits are still there in the patch copy mailed to the list.

Specifically in helpers/external_acl/kerberos_ldap_group/support_ldap.cc
get_bin_attributes() bits I can see :

* redux function setup:

+ LDAPMessage *msg;
+ char **attr_value = NULL;
+ int *attr_len=NULL;
+ size_t max_attr = 0;
+
+ attr_value = *ret_value;
+ attr_len = *ret_len;

should be:
+ char **attr_value = *ret_value;
+ int *attr_len = *ret_len;
+ size_t max_attr = 0;

* main for loop:
  - for (msg = ldap_first_entry
    + for (LDAPMessage *msg = ldap_first_entry

* drop these:
  BerElement *b;
  char *attr;

* switch case should be:
case LDAP_RES_SEARCH_ENTRY:
{
  BerElement *b = NULL;
  ...
  ber_free(b, 0);
} break;

* for loops inside that switch case should be:

 - for (attr = ldap_first_attribute...
    + for (char *attr = ldap_first_attribute...

 - int il; for (il = 0; ...
    + for (int il = 0; ...

Otherwise it looks okay.

Amos

>
> Markus
>
> -----Original Message----- From: Amos Jeffries Sent: Friday, August 08,
> 2014 1:28 PM To: squid-dev_at_squid-cache.org ; Markus Moeller Subject: Re:
> [PATCH] Kerberos configure patch + some cleanup
> On 8/08/2014 8:02 a.m., Markus Moeller wrote:
>> Are there any objections to this patch ?
>
> The audit results from me I accidentally sent in private.
> Do you have an updated patch with those fixes?
>
> Amos
>
>
>
Received on Sat Aug 09 2014 - 06:42:54 MDT