Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

On 23/06/2014 5:43 a.m., Tsantilas Christos wrote:
> Hi all,
>
> The attached patch replaces existin annotation values with the new one
> received from helpers.
>
> Just one question. We are documenting key-value pairs in cf.data.pre
> only for url-rewriter helpers, but annotations works for all squid helpers.
> Should we move the related url-rewriter section to a global section? If
> yes where?
>

The external_acl_type and store_id_program document their protocol and
keys as well. Those interfaces are one where users commonly are required
to create custom helpers so having it in these docs is helpful if a bit
odd. The other interfaces (auth, logging, unlinkd, diskd, pinger, etc)
which do not document the protocol in detail generally the Squid bundled
helpers are used and the docs reference the wiki for the more advanced
users.

Amos
Received on Mon Jun 23 2014 - 05:52:13 MDT