Re: [PATCH] logformat annotation fixes

On 25/04/2014 2:12 a.m., Tsantilas Christos wrote:
> Currently note values printed with "%note" formating code, which
> contain non alphanumeric characters, were quoted and quotes were then
> escaped, resulting in bizarre logged rendition of empty or simple values
> (often received from various helpers):
> %22-%22
> %22Default_Google%22
> %22pg13,US%22
>
> This patch:
> - does not use quotes to print annotations
>
> - Allow system admin to define a separator to use for logged
> annotations. The %note logformat accepts the following argument:
> [name][:separator]
> The separator can be one of the ',' ';' or ':'. By default, multiple
> note values are separated with "," and multiple notes are separated with
> "\r\n". When logging named notes with %{name}note, the explicitly
> configured separator is used between note values. When logging all notes
> with %note, the explicitly configured separator is used between
> individual notes. There is currently no way to specify both value and
> notes separators when logging all notes with %note.
>
> - Makes the Format::Token::data a struct (now is a union) and initialize
> Format::Token::data data members in Format::Token::Token constructor.
>
> This is a Measurement Factory project
>

+1.

Amos
Received on Sun Apr 27 2014 - 14:31:16 MDT