Re: [PATCH 4/8] reconfiguration leaks: Cache Manager menu items

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Fri, 25 Apr 2014 19:55:12 +1200

On 25/04/2014 12:50 p.m., Alex Rousskov wrote:
> Do not register the same Cache Manager action more than once, to avoid
> wrong mgr:menu output and the impression of a reconfigure memory leak.
>
> The old code was comparing action object pointers, which could not work,
> and was adding the same action on every reconfigure call for modules
> that register with Cache Manager during [re]configuration.
>
> We already have a working method for finding registered actions. Use it.
>
> Alex.
>

Ouch. I thought we had this is trunk a while back...

+1 if it still needs to go in.

Amos
Received on Fri Apr 25 2014 - 07:55:17 MDT

This archive was generated by hypermail 2.2.0 : Fri Apr 25 2014 - 12:00:16 MDT