Re: [PATCH] SBuf conversion of HttpRequestMethod

On Tue, Apr 8, 2014 at 5:45 AM, Amos Jeffries <squid3_at_treenet.co.nz> wrote:
>
> Add mk-sbuf-strings.awk script to produce a global array of SBuf for the
> string objects of registered methods. This can be re-used to convert
> other enum name arrays as we go forward.
>
> Use an SBuf to store unknown method names "image". Including a few
> string comparison upgrades.
>
> Removes use of RequestMethodStr() wrapper in debugs to reduce the amount
> of overheads calling c_str() when debug printing method strings.

Hi,
  can't we have RequestMethodStr just return a SBuf?

In the awk script:
/^namespace [a-zA-Z]+/
What about
/^namespace *[a-zA-Z]+/
(multiple whitespaces are bad form, but are legal)

Apart from that, LGTM

-- 
    Francesco