Re: [PATCH] SBufList

Sorry for bumping in but for this:

Alex Rousskov wrote:
> And yes, I know I used std::accumulate twice in my sketch. This just
> proves that STL is not my strong suit (and illustrates why I hate
> sketching things and effectively ending up taking responsibility for any
> problems).

Eliezer writes:
There are possible problems that can fall into some tiny cracks between
taking responsibility to consider a sketching!
It was a good one.(better then a one from me)
##END

On 03/12/13 00:54, Alex Rousskov wrote:
> Yes, your "append into the unused MemBlob space if possible"
> optimization is working well here. The accumulate-based solution still
> feels rather fragile to me, but I do not have enough reasons to push for
> a redesign.

Eliezer Writes:
And I am sure we can find a case which will cause a redesign.
Once we can find two-three of these cases it will be strong enough to
consider these.

What kind of result can be felt as fragile?
There is the worst case scenario of memory leakage which we are probably
are not talking about.
There is another worst case that can be identified by "slow" response.

And I do still think that by myself I cannot think of any test-case
which can verify that a "path" of a request will result a redesign of
the whole patch.

If there is any case that is hard as Titanium I will be more then glad
to read and understand it.

Eliezer
Received on Mon Dec 02 2013 - 23:57:00 MST