Re: [PATCH] Unknown cfg function

On 07/29/2013 11:25 AM, Amos Jeffries wrote:
> Looks like nobody actually ran the trivial "-k parse" test using 3.HEAD
> or the initial quoted strings code.

Or perhaps nobody ran such a test with non-trivial regular expressions
in squid.conf? I know I tested [very] early versions of the quoted
strings code (which is now running on live servers), but I suspect my
configs did not use regular expressions that trigger these problems or
perhaps the early code was different enough not to trigger them: IIRC,
there have been many revisions of the original patch.

> Attached is a patch which adds a secondary form of undo for handling
> incorrectly identified ConfigParser::FunctionNameToken elements. Instead
> of aborting Squid on any non-function token containing a '(' we take the
> wrongly identified assumed function name element and reform it with the
> '(' delimiter and trailing element. The resulting aggregate token which
> should have been identified initially is then sent to the upper parser
> layer.

After this patch, if I type parametres(foo) instead of parameters(foo),
will Squid think that I am defining a regular expression instead of
importing foo where my true regular expressions are stored?

Alex.
Received on Mon Jul 29 2013 - 18:40:41 MDT