Re: [PATCH] Better support compiler conditional flags on clang

On 22/06/2013 4:17 p.m., Amos Jeffries wrote:
> On 22/06/2013 2:50 a.m., Kinkie wrote:
>> Hi,
>> different clang versions have different compiler flags.
>> This patch tests if the -Wno-error=parentheses-equality and
>> -Qunused-arguments flags are available before setting them at
>> configure-time.
>
> I'm scratching my head over this one a little.
>
> You are testing for each flag independently.
>
> I was of the understanding that the purpose of -Qunused-arguments was
> to enable the compiler to run with the -W flag. Which implies that the
> -W flag will fail its individual SQUID_CC_CHECK_ARGUMENT().
> The if-statement causes either both to be used or neither. Was not the
> idea that the -W should be used, and -Q only necessary if -W failed?
>
> Amos

Any progress on this? it does seem to be the last easily fixed build
issue currently in trunk.

Amos
Received on Thu Jul 04 2013 - 09:21:37 MDT