Re: [PATCH] Fix building with openssl problems

On 30/06/2013 12:47 a.m., Tsantilas Christos wrote:
> The attached patch fixes two problems
>
> - Bug 3868: The SSL_CTX_new in newer openSSL releases requires a const
> 'SSL_METHOD *' argument and in older releases requires non const
> 'SSL_METHD *' argument. Currently we are trying to identify openSSL
> version using the OPENSSL_VERSION_NUMBER define but looks that
> sometimes we are failing to correctly identify the cases.
>
> - sk_OPENSSL_PSTRING_value is buggy in early openSSL-1.0.0? releases
> causing compile errors in squid. Also see the "compiling errors on
> squid3 head 919" thread in squid-dev mailing list.

These both seem to be bug 3297. (I have marked 3868 as a duplicate now).

And a part of bug 3759 which was missed.

> I tried to compile it using various openSSL versions. I hope it is OK
> and fixes the above problems.

What a mess. Thank you for figuring it out.

+1.

Please commit with both: --fixes squid:3297 --fixes squid:3759
But only needs "Bug 3297: ..." in the comment first line.

Amos
Received on Sun Jun 30 2013 - 02:05:51 MDT