Re: [PATCH] Error page format codes upgrade

On 06/12/2013 02:13 AM, Amos Jeffries wrote:
>>>>> /* - IP stuff */
>>>>> - str.Printf("ClientIP: %s\r\n",
>>>>> src_addr.NtoA(ntoabuf,MAX_IPSTRLEN));
>>>>> +// char ntoabuf[MAX_IPSTRLEN];
>>>>> +//XXX str.Printf("ClientIP: %s\r\n",
>>>>> src_addr.NtoA(ntoabuf,MAX_IPSTRLEN));
>>>> Is this change intentional?
>>> Yes with the src_addr removal we have no way to identify the client IP
>>> in that code anymore.
>> It is not clear what that XXX implies. Add a comment?
>
> Do you think we need to display the client IP there anymore? I'm not
> sure we do.

I suspect that we do not have to display it because it is available as
%>a, right?

On the other hand, if we can handle %>a, why introduce an interface
change here? Should not we keep supplying "ClientIP:" using %>a code or
similar?

Cheers,

Alex.
Received on Wed Jun 12 2013 - 17:14:32 MDT