Re: [PATCH] support parameters for no-cache and private

On 23/02/2013 2:56 p.m., Amos Jeffries wrote:
> On 23/02/2013 10:20 a.m., Alex Rousskov wrote:
>> On 02/21/2013 06:26 PM, Amos Jeffries wrote:
>>
>>> Adjusted patch to drop the odd NP, rework CC:private operation on
>>> broken
>>> parameters, and fix the segfault.
<snip>
>>
>>>> Since we now support HTTP/1.1 storage and revalidation of
>>>> Cache-Control:no-cache it is important that we at least detect the
>>>> cases where no-cache= and private= contain parameters and handle them
>>>> properly whenever possible.
>>>>
>>>> AFAIK these are still rare occurances due to the historic lack of
>>>> support. So for now Squid just detects and exempts these responses
>>>> from the caching performed. The basic framework for adding future
>>>> support of these HTTP/1.1 features is made available
>>>>
>>> Please run this past Co-Advisor to confirm the private="..." and
>>> no-cache="..." cases are now all "Precondition Failed".
>> Confirmed. Please note that CC:private="..." cases were failing
>> precondition before the patch as well. Apparently, somebody fixed
>> CC:private handling some time after r12394 and before your patch.
>

Please re-check this adjusted patch. It should meet the additional
points of retaining the most conservative interpretation on broken input
headers.

Amos