Re: [PATCH] Generated SBuf::find() test cases

On 27/02/2013 1:24 p.m., Alex Rousskov wrote:
> On 02/26/2013 03:56 PM, Amos Jeffries wrote:
>
>> I've applied it to me checkout of stringng and am hitting build errors.
>> Will see what I can do about that and post an update hopefully later
>> today..
>>
>>
>> ... unless you are able to post one Alex?
> I am not getting build errors (or I would not post the patch in the
> first place, at least not without a warning!). The patch built fine and
> was tested, which is the default for all the patches I post. It did fail
> "make check" because of SBuf problems, as reported.
>
> I was using stringng r9612. If you need help fixing build errors (which
> do not surprise me because, in part, the code has to deal with lots of
> signed/unsigned interactions), please share them.
>
>
> Thank you,
>
> Alex.
>

I'm hitting two when building on west (GCC 3.4).

First one was missing #include <set> in SBufFindTest.h

Second one is not

depbase=`echo tests/SBufFindTest.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;
g++ -DHAVE_CONFIG_H
-DDEFAULT_CONFIG_FILE=\"/usr/local/squid/etc/squid.conf\"
-DDEFAULT_SQUID_DATA_DIR=\"/usr/local/squid/share\"
-DDEFAULT_SQUID_CONFIG_DIR=\"/usr/local/squid/etc\"
-I../.././test-suite/.. -I../.././test-suite/../include
-I../.././test-suite/../lib -I../.././test-suite/../src -I../include
-I/usr/local/include -I/usr/include -I/usr/include
-I../.././test-suite/../libltdl -I../src
-I../.././test-suite/../libltdl -I/usr/include -I/usr/include
-I/usr/include -I/usr/include -g -O2 -I/usr/local/include -MT
tests/SBufFindTest.o -MD -MP -MF $depbase.Tpo -c -o tests/SBufFindTest.o
../.././test-suite/../src/DiskIO/../.././test-suite/../src/tests/SBufFindTest.cc
&& mv -f $depbase.Tpo $depbase.Po
../.././test-suite/../src/DiskIO/../.././test-suite/../src/tests/SBufFindTest.cc:
In member function `void SBufFindTest::run()':
../.././test-suite/../src/DiskIO/../.././test-suite/../src/tests/SBufFindTest.cc:43:
error: `Placement' is not a class or namespace
*** Error code 1

Amos
Received on Wed Feb 27 2013 - 08:41:43 MST