Re: [PATCH] Negotiate NTLM fix for Squid 3.2.3

On 12.12.2012 02:03, Steve Hill wrote:
> Following the previous discussions about the broken Negotiate
> authenticator in Squid 3.2, I've written the attached small patch
> which I believe fixes the problem.
>
> The Negotiate authenticator instantiates a config object as the
> negotiateConfig variable. I've examined Squid 3.1 and the NTLM
> authenticator did the same. In Squid 3.2, the Negotiate
> authenticator
> does not correctly initialise the negotiateConfig instance with the
> configuration. The NTLM authenticator no longer has a similar
> instance, so I believe this is no longer required for Negotiate
> either
> and that its removal wasn't completed correctly in the transition
> between 3.1 and 3.2.

Doh. Yes, quite right.

>
> I've used the NTLM authenticator as the basis for this code and I
> think it makes sense. Preliminary testing shows that it works.

Thank you. Excellent catch. I will apply this shortly.

Amos
Received on Wed Dec 12 2012 - 02:33:03 MST