Re: [PATCH] c++-stream-ify purge/conffile.cc

On 10/24/2012 11:14 AM, Kinkie wrote:
> Hi,
> the attached patch changes purge/conffile.cc to use c++ file streams
> instaed of C-FILE handles.
>
> Ok for merging?
>

> - FILE* in = fopen( fn, "r" );
> - if ( in == NULL ) {
> + std::ifstream cfgin(fn);
> + if ( !cfgin.good() ) {
> fprintf( stderr, "fopen %s: %s\n", fn, strerror(errno) );
> return -1;

This is not exactly a 1:1 conversion. The old and the patch code might
behave differently on empty files. To preserve old behavior, you would
need to do

    if (!cfgin) {
        ...
    }

instead of calling .good().

HTH,

Alex.
Received on Thu Oct 25 2012 - 16:29:26 MDT