Re: [PATCH] HTTP/1.1 response caching upgrade

On 10/17/2012 06:22 PM, Amos Jeffries wrote:
> On 18.10.2012 04:52, Alex Rousskov wrote:
>> On 10/16/2012 03:24 AM, Amos Jeffries wrote:
>>> Updated patch with requested changes.
>>
>>
>>> +#if USE_HTTP_VIOLATIONS // response header Pragma is undefined in HTTP
>>> + else {
>>> + // Expensive calculation. So only do it IF the CC:
>>> header is not present.
>>> +
>>> + /* HACK: Pragma: no-cache in _replies_ is not documented
>>> in HTTP,
>>> + * but servers like "Active Imaging Webcast/2.0" sure do
>>> use it */
>>> + if (rep->header.has(HDR_PRAGMA) &&
>>> +
>>> rep->header.hasListMember(HDR_PRAGMA,"no-cache",','))
>>> + EBIT_SET(entry->flags, ENTRY_REVALIDATE);
>>> + }
>>> +#endif
>>
>> Pragma is defined in HTTP RFC 2616. Even if that definition is removed
>
> *request* Pragma is defined.

Just for the record, Pragma is defined as a general header, applicable
to both requests and responses. However, the meaning of no-cache
directive in _responses_ is "not actually specified" (to quote RFC 2616).

Cheers,

Alex.
Received on Thu Oct 18 2012 - 16:31:08 MDT