Re: [PATCH] Portable flexible arrays instead of r12255

On 16.10.2012 08:56, Alex Rousskov wrote:
> Hello,
>
> Trunk r12255 made Clang compiler happy by removing flexible
> nonPod[]
> arrays. Unfortunately, it also moved shared memory items into local
> memory (in some cases uninitialized). See the "[PATCH] Improve CLANG
> support" thread.
>
> The attached patch provides a Clang-friendly flexible array
> replacement
> while keeping items in the shared memory (and using placement-new
> initialization). The code may have become even less readable, but
> hopefully more portable.
>
> The changes passed build farm tests (except a couple of nodes with
> Jenkins-related build problems unrelated to the code).
>
>
> Thank you,
>
> Alex.

+1. Looks good, please apply soonest.

Amos
Received on Mon Oct 15 2012 - 21:48:16 MDT