Re: /bzr/squid3/trunk/ r12345: Do not check 'reply content_length is too big' condition twice.

On 10/05/2012 05:36 PM, Alex Rousskov wrote:
> ------------------------------------------------------------
> revno: 12345
> committer: Alex Rousskov <rousskov_at_measurement-factory.com>
> branch nick: trunk
> timestamp: Fri 2012-10-05 17:36:22 -0600
> message:
> Do not check 'reply content_length is too big' condition twice.
>
> The check got duplicated was
>
> 4410
> committer: hno
> branch nick: HEAD
> timestamp: Wed 2000-05-03 00:49:26 +0000
> message:
> hno squid-2.2.STABLE2.to_large_objects-2.patch
> Squid-2.2.STABLE2: Don't swap out objects > maximum_object_size
> modified:
> src/store.cc
>

Amos,

    Here is the correct version of that corrupted commit message for
trunk r12345:

-----------
Do not check 'reply content_length is too big' condition twice.

Saves a few CPU cycles. No visible runtime effects are expected.

The semi-duplicate check was introduced in trunk r4410 while trying to
prevent huge objects from being swapped out. It is not clear to me why
that change helped at the time (but it could have something to do with
negative content_length values and their effect on then-current size types).
-----------

Thank you,

Alex.

> } else if ((getReply()->content_length > 0 &&
> getReply()->content_length
> > Config.Store.maxObjectSize) ||
> mem_obj->endOffset() > Config.Store.maxObjectSize) {
> debugs(20, 2, "StoreEntry::checkCachable: NO: too big");
> ++store_check_cachable_hist.no.too_big;
> - } else if (getReply()->content_length > Config.Store.maxObjectSize) {
> - debugs(20, 2, "StoreEntry::checkCachable: NO: too big");
> - ++store_check_cachable_hist.no.too_big;
> } else if (checkTooSmall()) {
Received on Sat Oct 06 2012 - 21:37:25 MDT