Re: [PATCH] Fix testRock on FreeBSD

From: Kinkie <gkinkie_at_gmail.com>
Date: Sat, 22 Sep 2012 19:01:23 +0200

> I suggest adding "#if HAVE_UNISTD_H" (because other Squid code uses
> that, albeit not consistently) and committing to see what happens on the
> build farm.

Will do - however I'm quite convinced that for so well-codified
headers we should rather remove it everywhere.

> You may also want to check for NULL return for getcwd() (our main.cc
> does that) and use "." if it is NULL, but such cases should be rare.

The man page mentions that getcwd will always return the buffer
argument that was passed.
I'm using the return value only because there is one and the compiler
will complain if I don't use it.
But sure, after all it's just one line of code.

Polishing and committing.
This probably also belongs to 3.2

-- 
    /kinkie
Received on Sat Sep 22 2012 - 17:01:30 MDT

This archive was generated by hypermail 2.2.0 : Sun Sep 23 2012 - 12:00:07 MDT