Re: [PATCH] remove squid-old.h

On 08/16/2012 12:56 AM, Kinkie wrote:
>> I am guessing this is the patch that broke build in numerous places. I
>> am surprised it was not reverted upon the first signs of trouble. Here
>> are some of the errors that I see:
>
> Prior to committing I have run a test-builds.sh on my kubuntu machine
> and it turned out fine; apparently the more recent kernel and/or glibc
> and/or gcc triggers some more permissive include paths.

AFAICT, the problems are related to missing #includes (a header that was
included via squid-old.h is no longer included). For example,
src/adaptation/ecap/MessageRep.cc is now missing protos.h, which
provides a urlParse() declaration.

A test build that enables ssl_crtd or eCAP could not succeed so I am
guessing your test-builds.sh does not enable them. I did not check
whether any other features are affected.

Will you fix those bugs or is it now our responsibility to clean up the
modules we care about?

Thank you,

Alex.

>>> helper.cc: In member function ‘void Ssl::Helper::Init()’:
>>> helper.cc:54: error: ‘strwordtok’ was not declared in this scope
>>> helper.cc:55: error: ‘wordlistAdd’ was not declared in this scope
>>> helper.cc:68: error: ‘wordlistAdd’ was not declared in this scope
>>> helper.cc: In member function ‘void Ssl::Helper::Shutdown()’:
>>> helper.cc:81: error: ‘wordlistDestroy’ was not declared in this scope
>>> MessageRep.cc: In member function ‘virtual void Adaptation::Ecap::RequestLineRep::uri(const libecap::Area&)’:
>>> MessageRep.cc:210: error: ‘urlParse’ was not declared in this scope
>>> MessageRep.cc: In member function ‘virtual libecap::Area Adaptation::Ecap::RequestLineRep::uri() const’:
>>> MessageRep.cc:218: error: ‘urlCanonical’ was not declared in this scope
>>> ServiceRep.cc: In member function ‘virtual void Adaptation::Ecap::ServiceRep::finalize()’:
>>> ServiceRep.cc:114: error: ‘DBG_IMPORTANT’ was not declared in this scope
>>> ServiceRep.cc:114: error: no match for ‘operator<<’ in ‘"WARNING: configured ...
Received on Thu Aug 16 2012 - 16:01:09 MDT