Re: [PATCH] Refactor ufscommon into individual include/code files

On 8/08/2012 4:33 a.m., Kinkie wrote:
> Hi all,
> here's an update on this effort, which in the meantime has morphed
> somewhat: the DBG_* and CBDATA_CLASS changes have already landed to
> trunk, and this project has been morphed into a SourceFormat-refactor
> project (scope: src/fs/ufs/* )
>
> This bundle does:
> - introduce the Fs::Ufs namespace
> - split classes into relevant header- and implementation- files
> - change a couple of int-used-as-bool to proper bool method signatures
> - for some classes with a constructor (but no default constructor) it
> explicitly disables default constructor, copy constuctor and
> assignment operator
>
> It does not:
> - remove the UFS prefix from ufs-related classes.
>
> There are no functional changes, only code refactoring.
>
> The new branch location is lp:~kinkie/squid/sourceformat
>

src/fs/ufs/UFSStoreState.h
  * CBDATA_CLASS location needs syncing with the change in trunk

Otherwise +1.

Amos
Received on Wed Aug 08 2012 - 07:18:42 MDT