Build failed in Jenkins: 3.HEAD-i386-OpenBSD #1332

See <http://build.squid-cache.org/job/3.HEAD-i386-OpenBSD/1332/changes>

Changes:

[Alex Rousskov] Bug 3466: Adaptation stuck on last single-byte body piece

Changed StoreEntry::bytesWanted(range) to return range.end when the entry can
accommodate range.end bytes. This makes it possible to use that method for
single-byte ranges. Old code returned zero for such ranges, which was
difficult to distinguish from situations where no bytes were wanted at all.

TODO: The StoreEntry::bytesWanted(range) API is left undocumented because it
seems to be slightly broken and/or inconsistent with callers and with the
DelayId::bytesWanted(min, max) API. AFAICT, we should convert
StoreEntry::bytesWanted API from range-based to min/max-based or even just
max-based.

Store Entry API does not use the lower end of the range (except for the
now-removed assertion that the range is not empty). I suspect that Store API
was meant to be used with (first, last+1) "byte position" parameters (returning
the number of bytes wanted) while the DelayId API was meant to be used with
(min, max) "number of bytes" parameters. However, StoreEntry::bytesWanted
implementation does not follow this assumption so perhaps my speculation is
wrong and there are more problems, including this change.

------------------------------------------
Started by upstream project "3.HEAD-amd64-CentOS-5.3" build number 1884
Building remotely on obsd-49-x86 in workspace <http://build.squid-cache.org/job/3.HEAD-i386-OpenBSD/ws/>
$ bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-i386-OpenBSD/ws/>
info result: bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-i386-OpenBSD/ws/> returned 0. Command output: "12128 squid3@treenet.co.nz-20120508012110-qk77qou71es8ykzi
" stderr: ""
[3.HEAD-i386-OpenBSD] $ bzr pull --overwrite http://bzr.squid-cache.org/bzr/squid3/trunk/
http://bzr.squid-cache.org/bzr/squid3/trunk is permanently redirected to http://bzr.squid-cache.org/bzr/squid3/trunk/
 M src/Server.cc
 M src/Store.h
 M src/client_side_request.cc
 M src/store.cc
All changes applied successfully.
Now on revision 12129.
$ bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-i386-OpenBSD/ws/>
info result: bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-i386-OpenBSD/ws/> returned 0. Command output: "12129 rousskov@measurement-factory.com-20120508181408-wom5hn70pr0jfysh
" stderr: ""
[3.HEAD-i386-OpenBSD] $ bzr log -v -r revid:squid3_at_treenet.co.nz-20120508012110-qk77qou71es8ykzi..revid:rousskov_at_measurement-factory.com-20120508181408-wom5hn70pr0jfysh --long --show-ids
Getting local revision...
$ bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-i386-OpenBSD/ws/>
info result: bzr revision-info -d <http://build.squid-cache.org/job/3.HEAD-i386-OpenBSD/ws/> returned 0. Command output: "12129 rousskov@measurement-factory.com-20120508181408-wom5hn70pr0jfysh
" stderr: ""
RevisionState revno:12129 revid:rousskov_at_measurement-factory.com-20120508181408-wom5hn70pr0jfysh
[3.HEAD-i386-OpenBSD] $ /usr/local/bin/bash /tmp/hudson4261758605668258190.sh
/tmp/hudson4261758605668258190.sh: line 3: /root/bin/hudson-build: No such file or directory
/tmp/hudson4261758605668258190.sh: line 3: exec: /root/bin/hudson-build: cannot execute: No such file or directory
Build step 'Execute shell' marked build as failure
Received on Tue May 08 2012 - 20:12:25 MDT