Re: [PATCH] IPv6 split-stack support for ICP, HTCP, SNMP

On 21.03.2012 18:49, Amos Jeffries wrote:
> On 20/03/2012 5:10 p.m., Alex Rousskov wrote:
>> On 03/15/2012 05:08 AM, Amos Jeffries wrote:
>>> Run-time testing begins this weekend, but it passes build testing
>>> and I
>>> fgured it was ready for an audit check. If anyone else wants to
>>> assist
>>> testing it that would be welcome. I am proposing this to go into
>>> trunk
>>> for squid-3.3.
>>>
>>>
>>> Split-stack support for ICP, HTCP, SNMP
>> FWIW, it would be better if http_port_list renaming and moving was
>> not
>> done while implementing the primary patch changes IMHO. It seems
>> like
>> you did not need to modify http_port_list itself and now it is not
>> clear
>> which of those modifications I can complain about without being told
>> that any further polishing is outside your patch scope. Besides
>> complicating review, combining functional and style changes would
>> also
>> make conflict resolution more difficult/risky for those of us who
>> are
>> modifying port-related code.
>
> Okay. I'm happy to split this in two parts:
> 1) cosmetic: renaming of http_port_list to AnyP::PortCfg. Renaming
> the incoming_* config directives and improving their documentation
> 2) functional: migration of UDP ports to use AnyP::PortCfg
>

Attached is the functional part of the patch for review.

Amos