Re: [PATCH] remove assert(ch->auth_user_request != NULL)

On 27/10/2011 5:15 p.m., Amos Jeffries wrote:
> On 27/10/11 04:06, Alex Rousskov wrote:
>> On 10/25/2011 11:59 PM, Amos Jeffries wrote:
>>> external ACL soemtimes cannot find the credentials in ACL Checklist
>>> even
>>> if they are attached to the HTTPRequest object.
>>>
>>> This seems to happen when the checklist is created and the line match
>>> started before the credentials are known.
>>>
>>> Unless someone knows of a better place to duplicate the credentials
>>> reference from request to checklist. I would like to apply this
>>> patch to:
>>>
>>> * locate the %LOGIN value from either place where credentials can be
>>> found,
>>> * updates the checklist if it was unset,
>>> * passes '-' to the helper if no credentials at all were given.
>>>
>>> Although the earlier logics forcing a lookup means this '-' case should
>>> not happen.

In absence of objections this has been applied to trunk as rev11917.

Amos
Received on Sun Dec 04 2011 - 06:51:05 MST