Re: /bzr/squid3/trunk/ r11707: Send RST packet when closing an ICAP connection after a transaction error.

On 09/06/2011 04:07 PM, Amos Jeffries wrote:
> On Tue, 06 Sep 2011 11:57:57 -0600, Alex Rousskov wrote:
>> ------------------------------------------------------------
>> revno: 11707
>> committer: Alex Rousskov <rousskov_at_measurement-factory.com>
>> branch nick: trunk
>> timestamp: Tue 2011-09-06 11:57:57 -0600
>> message:
>> Send RST packet when closing an ICAP connection after a transaction
>> error.
>>
>> This helps identify abnormal transaction termination at the ICAP
>> server. The
>> code is from a production-running branch and was proven useful in some
>> environments (especially if the ICAP service needs help correctly
>> dealing with
>> prematurely terminated transfers), but it is not yet clear whether the
>> advantages of doing this on a regular basis outweigh the overheads.
>> If not,
>> we will need a squid.conf parameter to control connection closing
>> behavior.
>> modified:
>> src/adaptation/icap/ServiceRep.cc
>> src/adaptation/icap/ServiceRep.h
>> src/adaptation/icap/Xaction.cc
>
>
> This would be RST the "other direction" as discussed in bug 2042 correct?

No, this change is about a brand new RST sent by Squid to the ICAP
server. Bug 2042 discusses "forwarding" to the HTTP client a RST sent by
an HTTP or ICAP server to Squid. Different directions and different
motivation.

Cheers,

Alex.
Received on Wed Sep 07 2011 - 00:30:02 MDT