tor 2011-07-07 klockan 14:12 +1200 skrev Amos Jeffries:
> Up to you whether you want to commit an explicit reversal patch, or
> combine the undo into the new fixes and note it in the commit message.
> Doesn't bother me either way.
A useful rule of thumb is that if it's code that is meant for trunk only
then just move forward using a sensible commit message. But if there is
a possibility that the change needs to be backported then it's better to
first undo the bad change in a commit of it's own and then commit the
right change.
If it's trivial to undo the bad change then you may always do so if you
want, in order to keep your changes clean.
And finally, if the change is of such nature that it needs review then
the bad change should always be reversed separately before review,
enabling the review to focus on the actual change the review is about.
Regards
Henrik
Received on Fri Jul 08 2011 - 12:15:37 MDT
This archive was generated by hypermail 2.2.0 : Fri Jul 08 2011 - 12:00:04 MDT