Re: [PATCH] Log all transactions

On 03/31/2011 04:59 PM, Amos Jeffries wrote:
> On 01/04/11 09:36, Kinkie wrote:
>>> I left the "if (true)" guard to prevent indentation changes to the
>>> pretty long logRequest method, making the patch more difficult to
>>> understand. I will remove that otherwise useless guard during commit
>>> unless you think it should stay.
>>
>> +1, with the suggestion of possibly making the debugs() statement have
>> a lower priority (that is, make it harder to print).
>
> + and ditto on the debugs. 5 maybe 6for that IMO.
>
> And yes, please remove the if (true) and run the
> scripts/sourcemaintenance.sh over it before commit.

I used level-2 debugging in case this change leads to logging coredumps:
Amos used that approach in a different context recently, arguing that it
would be easier to request/get this debugging information that way.

Formatted and committed to trunk with level 5 as r11337.

Thank you,

Alex.
Received on Fri Apr 01 2011 - 14:37:44 MDT