Re: [MERGE] Replacing reply headers [was: Force Basic auth for Java applets]

 On Tue, 22 Mar 2011 12:15:16 +0100, Marco Beck wrote:
> Hi,
>
> the patch attached restores the functionality to replace reply
> headers as found in Squid 2 (header_replace worked for both
> request and reply headers back then) and updates the release
> notes as requested by Amos.
>
> The patch is against HEAD. I'm also using it with Squid 3.1.11
> where I had to s/IFDEF: USE_HTTP_VIOLATIONS/IFDEF: HTTP_VIOLATIONS/.
> In case a separate patch is needed, please let me know.
>
> Thanks,
> Marco
>
> P.S.: I'm not subscribed to squid-dev (only squid-users), please
> CC me when replying.
>
> ----- Forwarded message from Amos Jeffries <squid3_at_treenet.co.nz>
> -----
>
> Date: Fri, 18 Mar 2011 14:35:54 +1300
> From: Amos Jeffries <squid3_at_treenet.co.nz>
> To: squid-users_at_squid-cache.org
> Subject: Re: [squid-users] Force Basic auth for Java applets
>
> [...]
>> * Created with 'bzr send'; never used bzr before, so I don't know
>> if this is the usual way to send patches around...
>
> For us it is accepted, merge/send or diff patches.
>
> Just needs to go to the squid-dev mailing list with an appropriate
> commit
> message. This type of bzr merge patch needs a [MERGE] on the subject
> line
> for the automatics.
>
> I've done the audit part for this, looks fine. I'll port this back to
> 3.1
> stable as a regression fix, so the doc/release-notes/release-3.1.sgml
> file
> also needs updating as part of the patch (ignore the .html).
> Specifically; adding header_replace entry under changed config
> options to
> say its deprecated by request_header_replace. Along with entries for
> the
> two new names under added config options.
>
> Cheers.
>
> Amos
>
> ----- End forwarded message -----

 +1. Regression fix. Unless anyone has objections this will go in over
 the next day or so.

 Note that header_replace is still accepted (unlike header_access) due
 to 3.x so far to retain back-compat with the regression behaviour people
 may have come to assume from earlier 3.0-3.1 releases.

 Amos
Received on Tue Mar 22 2011 - 22:18:25 MDT