Re: [PATCH] bug 3081: comm layer cleanups for TCP acceptor

On Tue, 25 Jan 2011 17:42:03 -0700, Alex Rousskov
<rousskov_at_measurement-factory.com> wrote:
> On 01/22/2011 06:46 AM, Amos Jeffries wrote:
>
>> However we cannot drop the CommCbFunPtrCallT and AsyncCallT copy
>> constructors. Notice how they explicitly call AsyncCall(a,b,c) instead
>> of the AsyncCall copy contructor. Without this we loose the call
>> debugs() and the ID creation.
>>
>> Adding the assignment operator (undefined) and destructor (no-op) to
>> match our big-three requirements.
>>
>> New version attached. This clears up all the points we have been
talking
>> about. As well as several duplicate calls to switchTimeoutToData() in
>> FTP.
>
>
> Thank you for polishing this! I do not see any more problems.
>
>
> This is minor, but you do not need to use the "inline" keyword for
> methods that are immediately inlined, such as CommCbFunPtrCallT copy
> constructor.
>
> Cheers,
>
> Alex.

Wonderful. Thank you so much for the time you have been putting into the
audits.

Will fix that inline and commit in a few hours.

Amos
Received on Wed Jan 26 2011 - 00:55:31 MST