Re: [PATCH] Fix IP cache accounting

On 15/01/11 05:14, Alex Rousskov wrote:
> Fix IP cache accounting to avoid idle caches on busy servers.
>
> When maintaining the IP cache size, use the number of entries in the
> cache rather than the number of allocated and not freed
> MEM_IPCACHE_ENTRY objects. MEM_IPCACHE_ENTRY objects are used outside
> the cache for DNS queries. If queries leak (or perhaps when there are
> just a lot of them), the memory-pool-based count overestimates the cache
> size, sometimes to such a degree that the cache remains nearly empty
> despite lots of misses.
>
> Use memory-pool-based counter to estimate cache size also violates IP
> cache encapsulation boundaries because it effectively prevents others
> from using the same memory pool.
>
> Alex.
> P.S. I believe other recent changes may have fixed DNS query leaks
> mentioned here.

+1 after fqdncache gets an identical update. Same problems there.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.10
   Beta testers wanted for 3.2.0.4