Re: [RFC} threadsafe internal profiler

From: Kinkie <gkinkie_at_gmail.com>
Date: Tue, 11 Jan 2011 10:08:20 +0100

On Tue, Jan 11, 2011 at 8:03 AM, Amos Jeffries <squid3_at_treenet.co.nz> wrote:
> The profiler aufs assertions are caused by the profiler not being thread
> safe but attempting to account operations inside each of the AIO threads.
> Lack of thread safety is due to the stack the profiler maintains of what
> states are currently being counted.
>
> I don't believe we should be maintaining such a stack. Instead I think we
> should leverage the existing system stack by having the PROF_start(X) macro
> create a counter object in the local scope being counted. When the local
> scope exists for any reason the system stack object will be destructed and
> the destructor can accumulate the counters back into the global data.

+1. I like this.

-- 
    /kinkie
Received on Tue Jan 11 2011 - 09:08:28 MST

This archive was generated by hypermail 2.2.0 : Wed Jan 12 2011 - 12:00:04 MST