Re: [PATCH] Polish log formats

On 01/12/10 06:39, Henrik Nordström wrote:
> tis 2010-11-30 klockan 03:25 +1300 skrev Amos Jeffries:
>
>> So could you explain those condition please? It's not clear from the
>> code that they did anything beyond logging at the end of header parsing.
>> Or do you mean that by being done there they logged multiple lines per
>> request?
>
> Checking.. was some years since I looked at this while doing the
> log_format stuff.

Thanks. Looking forward to the results there.

>
> Both only logs if the corresponding header is in the request. And yes,
> this can be simulated by using an acl for the condition.
>
> useragent_log translates to
>
> acl has_useragent useragent .
> log_format useragentlog ....
> access_log /path/to/file useragentlog has_useragent
>
> and similar for referer_log using referer instead of useragent.

Ah. ? the code logging dash_str / "-" was cut-n-pasted, no changes by me.

It would be useful to have anyway for these logs. Will add it.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.9
   Beta testers wanted for 3.2.0.3