Re: [PATCH] SMP Cache Manager, Phase2

On 10/14/2010 07:20 AM, Amos Jeffries wrote:
> On 14/10/10 18:09, Alex Rousskov wrote:
>> SMP Cache Manager, Phase2 implementation.
>>
> <snip>
>>
>> More polishing left for future projects: Move CacheManager to Mgr
>> namespace and src/mgr/ directory. Use SBuf instead of String for
>> ActionParams and TypedMsgHdr. Rename Ipc::TypedMsgHdr to Ipc::Msg,
>> Ipc::SocketMsg, or similar because it maintains more than just msghdr
>> struct. Fix #include order in old source files affected by the
>> Mgr::RegisterAction change. More action aggregation and Phase3 changes.
>
>
> Thank you.
>
>
> Audit Checks:
> * please make sure all the new mgr/*.h in the include lists are not
> adding regressions. There seem to be a fair few added which are merely
> mussing up otherwise find lists.

Done. I tried to manually find and fix all the ones the patch broke.

> * Why double across the board for all the counters? does it accurately
> portray TB counts to the byte for large boxes?
>
> * don't forget to update SourceLayout with the src/mgr/ progress :)

These two were addressed earlier.

The changes are now committed as trunk r10994. Let's see what
portability bugs Hudson finds...

Thank you,

Alex.
Received on Thu Oct 28 2010 - 19:03:37 MDT