Re: /bzr/squid3/trunk/ r10908: Convert compat library to a full library.

On 10/03/2010 07:08 PM, Amos Jeffries wrote:
> On Sun, 03 Oct 2010 15:36:36 -0600, Alex Rousskov
> <rousskov_at_measurement-factory.com> wrote:
>> On 10/03/2010 08:42 AM, Amos Jeffries wrote:
>>> ------------------------------------------------------------
>>> revno: 10908
>>> committer: Amos Jeffries<amosjeffries_at_squid-cache.org>
>>> branch nick: trunk
>>> timestamp: Sun 2010-10-03 08:42:04 -0600
>>> message:
>>> Convert compat library to a full library.
>>>
>>> To be linked with LIBOBJS requires full local library status.
>>
>> It looks like this and an earlier related change broke things on Centos
>
> This was the fix for that earlier breakage.
>
> The fails that are showing up now are previously overlooked bugs, where
> $(COMPAT_LIB) was not being used by some of the test binaries. I'm
> build-testing the fix for all those right now.
>
>> and possibly elsewhere. Why do we need to link a library with LIBOBJS? I
>
>> know we did that before, but perhaps that code was wrong/outdated?
>>
>
> It seems to be valid as per the autoconf 2.6* documentation. It's the
> result of AC_REPLACE_FUNCS(). Using LIBOBJS requires linking with *_LIBADD
> and that requires a library.

Understood.

> Of course there is likely a way to do it without involving LIBOBJS at all.
> I'm happy to learn a better way if one is known.

I do not know of any. It looks like autoconf (AC_REPLACE_FUNCS and
friends) is just not geared towards convenience libraries.

Cheers,

Alex.
Received on Mon Oct 04 2010 - 01:13:59 MDT