Re: [MERGE] Clean up htcp cache_peer options collapsing them into a single option with arguments

On 08/22/2010 07:17 AM, Amos Jeffries wrote:
> Henrik Nordstrom wrote:
>> the list of HTCP mode options had grown a bit too large. Collapse them
>> all into a single htcp= option taking a list of mode flags.
>>
>
> Updated version of Henriks patch. (why did it not get committed last
> year when approved?)
>
> * parser bug fixed to handle a list of exactly one parameter without
> trailing comma (which the original would call bungled).
>
> * special parse case for htcp-oldsquid fully combined with new parser.
>
> * alters the cachemgr config dump to show the new syntax.
>
> Other than parse no operational changes. Fully backward-compatible and
> tested.

This is not an objection to the patch, but if the various htcp-foo
options set combine-able flags rather than a single "htcp" value, then
please consider using "htcp::flag" namespace syntax instead of the
"htcp=flag" assignment syntax.

Thank you,

Alex.
Received on Mon Aug 23 2010 - 21:28:26 MDT