Re: compat/unsafe.h

lör 2010-08-21 klockan 20:07 +1200 skrev Amos Jeffries:

> IMO some of them such as the malloc/calloc/free which only force a
> xfoo() version internal to Squid to be hard-coded should be done with a
> real symbol swap-in in the relevant header files. That way the code can
> go to using malloc/calloc/free and our custom wrappers plug-in silently
> to src/ code where appropriate.

Not entirely sure what you mean. If you mean that free() should silently
redirect to xfree() in src/ then I disagree. The two have slightly
different usage.

> Others like sprintf which are still actually enforcing non-use of unsafe
> functions should stay.

Many compilers and most auditing tools barfs on sprintf etc these days.
Not sure why gcc do not..

Regards
Henrik
Received on Sat Aug 21 2010 - 19:57:12 MDT