Re: New external_acl helper squid_kerb_ldap

Markus Moeller wrote:
>
> "Amos Jeffries" <squid3_at_treenet.co.nz> wrote in message
> news:4C5187D2.5010203_at_treenet.co.nz...
>> Markus Moeller wrote:
>>> Hi Amos,
>
> Hi Amos
>
>>>
>>> How does your time look like now ?
>>>
>>> Regards
>>> Markus
>>>
>>
>> Looks passable. I have not had time for a detailed view of the logics.
>> I'll commit this tomorrow with a name tweak, the naming scheme has
>> been through the external acl helpers too now. I'll just tack ext_ on
>> the front and _acl on the back of the existing binary name and update
>> the docs to match.
>>
>> One thing that worries me still is the RUN_IFELSE autoconf macros
>> still being added to configure.in. I'm sure there is a macro that
>> checked for defined values of things inside headers without running
>> stuff. If you can try and find that it would be great not to have to
>> run anything on build.
>>
>
> I have 4 RUN_IFELSE.
>
> The first is to check to check that ldap works with the provided
> libraries. Is that unusual ? Any other suggestion how to check ?

Um, okay. Thats reasonable on build. Duplicating at run-time may also be
useful since the particular run-time libraries are not always the ones
built against.

> The other three are to determine the LDAP vendor, which is a define
> statement in one of the ldap header files and as it is a string in a
> define I can not use any header grep nor proprocessor checks ( at least
> I do not know of any).

Nasty. Oh well.

Okay. Have applied to Squid-3.HEAD with the extra ext_*_acl bits on the
binary name and docs for the current naming style.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.6
   Beta testers wanted for 3.2.0.1