Re: New external_acl helper squid_kerb_ldap

Hi Amos,

   How does your time look like now ?

Regards
Markus

"Amos Jeffries" <squid3_at_treenet.co.nz> wrote in message
news:4C197FBD.9010009_at_treenet.co.nz...
> Markus Moeller wrote:
>> Hi Amos,
>>
>> did you have time to review the updated patch ?
>>
>> Thank you
>> Markus
>
> Hi Markus,
> Sorry I have not had time to review the second submission yet.
> I do not expect to have any good stretch of time to do it for the next two
> weeks either.
>
> Amos
>
>>
>>
>> "Markus Moeller" <huaraz_at_moeller.plus.com> wrote in message
>> news:hudjud$3i4$1_at_dough.gmane.org...
>>> Hi Amos,
>>>
>>> I updated the patch.
>>>
>>> Regards
>>> Markus
>>>
>>> "Amos Jeffries" <squid3_at_treenet.co.nz> wrote in message
>>> news:9b92235f13abdaf1c87f73c73c732865_at_mail.treenet.co.nz...
>>>> On Mon, 31 May 2010 23:47:40 +0100, "Markus Moeller"
>>>> <huaraz_at_moeller.plus.com> wrote:
>>>>> "Amos Jeffries" <squid3_at_treenet.co.nz> wrote in message
>>>>> news:90351e19016110c5e9fd1699187b55f6_at_mail.treenet.co.nz...
>>>>>> On Sun, 30 May 2010 16:15:14 +0100, "Markus Moeller"
>>>>>> <huaraz_at_moeller.plus.com> wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> I have converted my helper to kerberos_ldap_group ( not sure if
>>>> that
>>>>>> is
>>>>>>> the best name) and created a patch for inclusion into the head
>>>> revision.
>>>>>>
>>>>>>> Please review and let me know any feedback.
>>>>>>>
>>>>>>>
>>>>>>> Thank you
>>>>>>> Markus
>>>>>>
>>>>>> Hi Markus,
>>>>
>>>> Okay, some more checks.
>>>>
>>>> configure.in:
>>>> * According to the GNU docs pre-processor only directives are to be
>>>> avoided when possible since they do not guarantee a working binary.
>>>> Could
>>>> you use AC_COMPILE_IFELSE instead of the AC_EGREP_CPP and
>>>> AC_EGREP_HEADER
>>>> ?
>>>>
>>>> kerberos_ldap_group/README:
>>>> * Would you mind converting the README file to a man.8 page?
>>>> There is a template at th bottom of
>>>> http://wiki.squid-cache.org/ProgrammingGuide/ManualDocumentation
>>>>
>>>>
>>>> Amos
>>>>
>>>
>>
>>
>
>
> --
> Please be using
> Current Stable Squid 2.7.STABLE9 or 3.1.4
>