Re: PAC serving

ons 2010-07-14 klockan 00:53 +0000 skrev Amos Jeffries:

> Thats the plan. Those three objects I said we have to work with are the
> parameters available to internalStart().

My copy only have two parameters..

internalStart(HttpRequest * request, StoreEntry * entry)

> So far I have the else case of internalStart() doing stat() on the file
> and generating the HttpReply headers. But doing async serving of the file
> is muddy. I suspect if we are happy to loose caching and delay pools, ICAP,
> eCAP, etc. etc then using sendfile() in non-blocking mode straight to the
> client_fd would be fine.

I would avoid that at this level. Needs too many shortcuts in the rest
of the code..

we could however aim for working on an infrastructure where sendfile()
optimization would fall out naturally by the client streams figuring out
that there is no processing being done other than shuffling the data.

> I left it with a simple AsyncJob comm reader which pushed data into the
> StoreEntry and looped. Patch to follow when its had some error handling
> added and been run-tested.

Ok. Sounds good.

Please remember that you need an abort handler as well on the
StoreEntry, to handle when the client aborts the request.

Regards
Henrik
Received on Wed Jul 14 2010 - 01:02:10 MDT