Adding sockaddr_un to Ip::Address

On 06/30/2010 07:46 PM, Alex Rousskov wrote:

> 2. We had to clone comm_openex into comm_open_uds because Unix Domain
> Sockets do not use IP addresses. They use file names. We can unify and
> simplify related code if we add the file name (struct sockaddr_un) to
> Ip::Address. IIRC, Amos and I discussed this on IRC and decided that it
> is OK to add sockaddr_un to Ip::Address (because it is used as a general
> "network address" anyway), but I would prefer to hear more opinions
> before altering Ip::Address.

Is anybody against adding struct sockaddr_un, which is essentially a
file name or path, to Ip::Address? Doing so will significantly reduce
comm_open code duplication but will increase Ip::Address size as it
becomes even more of a general purpose NetworkAddress than it is today.

Thank you,

Alex.
Received on Thu Jul 08 2010 - 05:08:23 MDT