[PATCH] TCP logging & UDP Logging - Dhaval Varia

Dear Sir,

Please find the attached patch file for the

1. TCP logging (Newly created) ------- *modtcp.patch*
2. UDP logging (Modified)* -------* *modudpfix.patch
*
- the Udp fix should be kept separate from the ModTcp
Done
- Makefile.in files should not be included in the patch, they are generated
form Makefile.am
Done
- editor backup ( files ending in ~) files should not be included in the
patch Regarding the patch itself:
Done
- why two debugs() statements in logfile_mod_tcp_open? They seem to output
the same text.
Done
- Marking debugs() messages with a special string ("Dhaval from .." is
perfectly
fine during early development, it's much less useful once the code has
matured.
Done
- the error messages at line 935 of the patch seem odd.. do they apply at
all to TCP logging? They seem more like relics from a file logging
facility
Dont find in my line patch file. Please look at the attached new files

- how does this logging facility handle the case of overload? Will it block?
Will it discard messages? There doesn't seem to be any facility
to have it handle backpressure. Can you please explain it in detail ??

*would you please commit this TCP logging and UDP fix first??

I will see what to do to handle back pressure later.
*
*:)* Thanks & Best Regards.
----------------------------------------------------------------------------------------
Dhaval varia
(+91-9924343883)