Re: [PATCH] log virgin HTTP request headers

Robert Collins wrote:
> On Thu, 2010-01-28 at 09:09 -0700, Alex Rousskov wrote:
>> On 01/28/2010 06:07 AM, Robert Collins wrote:
>>> Just a small thing: can I suggest s/virgin/pristine/ ? Or
>>> s/virgin/received/ ?
>> Pristine may work, but we (and other adaptation related documents) use
>> virgin in many places already, including APIs.
>>
>> Received is a bad idea because an adapted message is also received.
>>
>>> virgin has a sexual connotation in some cultures, and can be confusing
>>> in a way that is avoidable.
>> Tell that to the Virgin Islands folks. :-)
>
> It was a passing thought, I'm not like 'omg must be done' for this: I
> certainly knew what it meant, but as its (AFAIK) the first config option
> in squid to specify virgins, I see potential for confusion :) Other
> possibilities:
> - source
> - external
> - unaltered
> - original
>
> I don't know that the config option has to meet the code, though
> obviously it is nice if it does.
>
> -Rob

I've been of a similar "is it a good idea" bent since I started seeing
these in the adaptation code. At least thats hidden away from regular view.

Now that Rob brings it up this could cause some people problems in our
middle-eastern and christian user bases. I recall something about the
word being a big issue for some large international organisations.

"original" sounds good for the docs/squid.conf side of things. Code: no
problems.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE7 or 3.0.STABLE21
   Current Beta Squid 3.1.0.15