Re: [noc] Build failed in Hudson: 3.HEAD-amd64-CentOS-5.3 #118

On Sun, 27 Sep 2009 22:41:51 +0200, Henrik Nordstrom
<henrik_at_henriknordstrom.net> wrote:
> sön 2009-09-27 klockan 03:02 +0200 skrev noc_at_squid-cache.org:
>
>> [Henrik Nordstrom <henrik_at_henriknordstrom.net>] Make ESI parser modules
>> expat and libxml2 dependent on their libraries
>>
>> The ESI parser system is actually pluggable. There is no reason we
should
>> require expat and libxml2. Just build what works.
>
> Sorry about that. Forgot to check compile without ESI enabled..
>
> Amos, regarding your change. Shouldn¨t the --with/--without force those
> libraries? Having detection within a --with seems wrong to me..

I was going with: default-enable + option to forceably disable for
behaviour.

So: <absent> == --with-xml2 == --with-xml2=foo (where foo != 'no')

>
> My preference for trunk is
>
> --with-... require that library to be present, fail the build if not.

If you like, I thought the point of your change was that one of the
libraries missing was not fatal. And that --with-X meant only that X should
be used if possible. Possibly the absence of both is fatal, in which case
the WARN at the end of my change should be made an ERROR again.

There is a small todo, the next step along was to be a default of 'auto'.
So either library present would enable ESI. Only fatal if not working and
--enable-esi explicitly set.

>
> --without-... don't use that lib even if present
>

Agreed. and currently works. It's the main case documented and expected to
be used.

--with-* being essentially a NOP.

Amos
Received on Mon Sep 28 2009 - 00:21:55 MDT