Re: Patch to authenticate securely to upstream ISA server(or others)

How about the attached ?

Markus

"Henrik Nordstrom" <henrik_at_henriknordstrom.net> wrote in message
news:1252272029.23776.54.camel_at_henriknordstrom.net...
> The patch had been somewhat corrupted in flight so had to apply it by
> hand, but running a test now.
>
> It's "no/lib" it is complaining on. Seem it comes from the "system
> default" test where check_mit / check_heimdal is called with a "random"
> $enableval from being called outside any AC_ARG_ENABLE macro.. (value in
> previous AC_ARG_ENABLE macro, i.e. the seam-64 one..)
>
>
> Hmm.. looking at the patch I don't think it's correct. The issue is that
> -L, -R and -I should only be set if there actually is any paths to set
> it to, not if the user uses ./configure --exec-prefix=... But it does
> hide the problem in my case with system integrated kerberos libs, but I
> guess it also breaks installs needing a non-system path to the kerberos
> installation.
>
> Regards
> Henrik
>
>
>
> sön 2009-09-06 klockan 14:37 +0100 skrev Markus Moeller:
>> Did this fix it ? You talk about -Rno/lib. I only saw -RNONE/lib. If
>> there
>> is the case of no then I need to check for no in the two ifs.
>>
>> Markus
>>
>>
>> "Markus Moeller" <huaraz_at_moeller.plus.com> wrote in message
>> news:h7scl8$r28$1_at_ger.gmane.org...
>> > This should fix it:
>> >
>> > --- configure.in 2009-09-04 02:06:24.000000000 +0100
>> > +++ configure.in.new 2009-09-05 01:47:34.875859258 +0100
>> > @@ -424,8 +424,12 @@
>> > [ squid_dir=$withval ]
>> > )
>> >
>> > +if test "x$exec_prefix" != xNONE; then
>> > eval ac_p_include=$includedir
>> > CPPFLAGS="$CPPFLAGS -I$ac_p_include -I../../../ -I../../../include/ -I$squid_dir/include
>> > -I$squid_dir/src -I$squid_dir"
>> > +else
>> > +CPPFLAGS="$CPPFLAGS -I../../../ -I../../../include/ -I$squid_dir/include
>> > -I$squid_dir/src -I$squid_dir"
>> > +fi
>> > AC_CACHE_CHECK([for SQUID at '$squid_dir' ],ac_cv_have_squid,[
>> > AC_TRY_RUN([
>> > #include <config.h>
>> > @@ -439,8 +443,12 @@
>> > ac_cv_have_squid=yes,
>> > ac_cv_have_squid=no)
>> > ])
>> > +if test "x$exec_prefix" != xNONE; then
>> > eval ac_p_lib=$libdir
>> > LDFLAGS="$LDFLAGS -L../../../lib -L$ac_p_lib $w_flag$ac_p_lib$w_flag_2"
>> > +else
>> > +LDFLAGS="$LDFLAGS -L../../../lib"
>> > +fi
>> > if test "x$ac_cv_have_squid" = "xyes"; then
>> > AC_DEFINE(HAVE_SQUID,1, [Define to 1 if you have SQUID])
>> > AC_CHECK_HEADERS(getaddrinfo.h getnameinfo.h util.h)
>> >
>> >
>> > Marksu
>> >
>> >
>> > "Henrik Nordstrom" <henrik_at_henriknordstrom.net> wrote in message
>> > news:1252072098.571.16.camel_at_henriknordstrom.net...
>> >> lör 2009-09-05 klockan 01:33 +1200 skrev Amos Jeffries:
>> >>
>> >>> Markus,
>> >>> these changes won't help the Fedora build with Squid-3.1 frozen.
>> >>> That
>> >>> will require a minimal change of probably just the configure.in.
>> >>
>> >> Squid-3.1 has now been packaged for Fedora 12, but so far without
>> >> squid_kerb_auth due to the configure mess adding invalid linker
>> >> library
>> >> path flags which the Fedora automatic package QA checks detects and
>> >> barfs loudly.
>> >>
>> >> The helper can be enabled if the configure bits is fixed. It builds
>> >> and
>> >> runs, it's just that the resulting binary is rejected by Fedora QA
>> >> checks (bad -R option no/lib).
>> >>
>> >> Regards
>> >> Henrik
>> >>
>> >>
>> >
>> >
>> >
>>
>
>