excessive RAM growth due to unlimited adapted body data consumption

From: Martin Huter <m.huter_at_phion.com>
Date: Tue, 18 Aug 2009 10:11:00 +0200

squids ICAP adaptation implementation does not check adapted body-pipes buffer
size before reading from an ICAP-server.

If the client does not read from the open connection (i.e. the user does not
confirm the browsers download-message-box in microsofts IE), squid keeps on
reading data from the ICAP server into the body pipe, whilst no more data
can be delivered to the client.
Thus the adapted body pipes buffer is growing unlimited which causes excessive
RAM growth.

this issue was reported as bugzilla bug 2619 and the attached patch (applies
to 3.1 and 3.HEAD) should fix the issue.

please review the patch and feel free to comment it.

-----------

i would like to subscribe the squid-dev mailing list.
my name is martin huter. i'm working as progammer at phion AG in austria.
i'm mainly working with C and C++ and among others i am responsible for our
squid service. currently i'm updating squid to version 3.1.

p.s.: many thanks to alex rousskov for his patient help on the appended patch.

cheers
martin huter

-- 
Martin Huter
Unit Manager
Release Manager
phion AG
Eduard-Bodem-Gasse 1
A-6020 Innsbruck
Tel:     +43 (0) 508 100
Fax:     +43 (0) 508 100 20
Mail:    m.huter_at_phion.com
Web:     http://www.phion.com
phion AG
Vorsitzender des Aufsichtsrates: Dr. Karl  Lamprecht
Vorstand: Dr. Wieland Alge, Mag. Günter Klausner
Sitz der Gesellschaft: 6020 Innsbruck, Österreich
Handelsgericht Innsbruck Firmenbuch: 184392s
UID-Nr:: ATU47509003

Received on Tue Aug 18 2009 - 14:12:02 MDT

This archive was generated by hypermail 2.2.0 : Fri Aug 21 2009 - 12:00:05 MDT